Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements. #44

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Minor improvements. #44

merged 1 commit into from
Apr 26, 2024

Conversation

zond
Copy link
Collaborator

@zond zond commented Apr 26, 2024

  • Extracted the xxd-provided ViSQOL model bytes to a separate versioned C++ file to simplify providing it by other means.
  • Removed the redundant ViSQOL typedef in goohrli.cc.
  • Added ViSQOL score support to compare.go.
  • Changed more float32's to float64's in Go land for uniformity.
  • Fixed the bug in visqol.cc where we use the length of the reference audio for the data of the degraded audio.

@zond
Minor improvements.
2731adb 
- Extracted the xxd-provided ViSQOL model bytes to a separate versioned
  C++ file to simplify providing it by other means.
- Removed the redundant ViSQOL typedef in goohrli.cc.
- Added ViSQOL score support to compare.go.
- Changed more float32's to float64's in Go land for uniformity.
- Fixed the bug in visqol.cc where we use the length of the reference
  audio for the data of the degraded audio.
@zond zond enabled auto-merge (rebase) April 26, 2024 09:24
@zond zond merged commit 801d813 into main Apr 26, 2024
2 checks passed
@zond zond deleted the maintenance branch April 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zond